fix(date-picker): prevent value changes when disabled or readonly#3822
Open
adrianschmidt-bot wants to merge 1 commit intoLundalogik:mainfrom
Open
fix(date-picker): prevent value changes when disabled or readonly#3822adrianschmidt-bot wants to merge 1 commit intoLundalogik:mainfrom
adrianschmidt-bot wants to merge 1 commit intoLundalogik:mainfrom
Conversation
📝 WalkthroughWalkthroughAdded protective guards to two event handler methods in the date-picker component to prevent calendar opening and input value changes when the component is disabled or read-only. Uses early returns and event propagation stopping to block interactions in these states. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Prevent the date picker from responding to focus events or input changes when the component is disabled or readonly. This ensures that disabled date pickers cannot be interacted with via keyboard or mouse. Fixes Lundalogik#3815
c6547a6 to
4d8ac58
Compare
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3822/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3815
Prevent the date picker from responding to focus events or input changes when the component is disabled or readonly. This ensures that disabled date pickers cannot be interacted with via keyboard or mouse.
Changes
showCalendar()to return early if disabled or readonlyhandleInputElementChange()to prevent value changes when disabled or readonlySummary by CodeRabbit