Initial image info for incomplete #2649
Open
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
CI gfxreconstruct build queued with queue ID 638402. |
Collaborator
|
CI gfxreconstruct build # 8772 running. |
Collaborator
|
CI gfxreconstruct build # 8772 passed. |
locke-lunarg
requested review from
MarkY-LunarG,
bradgrantham-lunarg and
davidlunarg
MarkY-LunarG
approved these changes
Feb 3, 2026
Contributor
MarkY-LunarG
left a comment
MarkY-LunarG
left a comment
There was a problem hiding this comment.
Good comment and change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the swapchain count isn't full image count,
GetSwapchainImagesKHRwill returnVK_INCOMPLETE. It should also initialize image infos. If it doesn't initialize, it won't be able to know whether the image info is for swapchain or not. It might also have other issues caused by lack of initialization.