Conversation
The watcher should not be installed when the handler is set with the new AddSpecialSignalHandlerFn but only when sigaction is used
Android's libsigaction gives the option to install signal handler with elevated priority compared the ones installed with sigaction. There are cases though which this does not work well.
|
CI gfxreconstruct build queued with queue ID 636273. |
|
CI gfxreconstruct build # 8753 running. |
|
CI gfxreconstruct build # 8753 passed. |
mikes-lunarg
left a comment
mikes-lunarg
left a comment
There was a problem hiding this comment.
LGTM. I'm curious what kinds of issues using libsigchain caused. Prior to this I assumed it worked the same as sigaction, just with a higher priority.
|
CI gfxreconstruct build queued with queue ID 637883. |
|
CI gfxreconstruct build # 8763 running. |
|
CI gfxreconstruct build # 8763 passed. |
Tbh I am not sure. There's an app that simply terminates without anything enlightening in logcat. Switching to sigaction just makes it work. It has to be related to the Android version as on a different phone with Android 15 (vs 14 ) it just works without this PR |
3 participants
Two commits in this PR: