Fix support for VK_KHR_pipeline_binary
#2634
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`VkPipelineCreateInfoKHR` is a particular structure as it can take any kind of `PipelineCreateInfo` in its `pNext` chain, in addition to being required to have a non-null `pNext` member. This was not correctly handled by the generated code, this commit aims at fixing the situation. Change-Id: Ie363804058867af5ff57ee32b062001c73f6368a
marius-pelegrin-arm
force-pushed
the
support-khr-pipeline-binary
branch
from
23ba2a6 to
4ad1a79
Compare
Collaborator
|
CI gfxreconstruct build queued with queue ID 633685. |
Collaborator
|
CI gfxreconstruct build # 8717 running. |
Collaborator
|
CI gfxreconstruct build # 8717 passed. |
| SetStructArrayHandleLengths<Decoded_VkPipelineBinaryHandlesInfoKHR>(pBinaries->GetMetaStructPointer(), pBinaries->GetLength()); | ||
| VkPipelineBinaryHandlesInfoKHR* out_pBinaries = pBinaries->IsNull() ? nullptr : pBinaries->AllocateOutputData(1, { VK_STRUCTURE_TYPE_PIPELINE_BINARY_HANDLES_INFO_KHR, nullptr }); | ||
| SetStructHandleLengths(pBinaries->GetMetaStructPointer()); | ||
| pBinaries->IsNull() ? nullptr : pBinaries->AllocateOutputData(1, { VK_STRUCTURE_TYPE_PIPELINE_BINARY_HANDLES_INFO_KHR, nullptr }); |
Contributor
There was a problem hiding this comment.
What are you setting to nullptr here? I think there's some code missing. (Same for 6507 below).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VkPipelineCreateInfoKHRis a particular structure as it can take any kind ofPipelineCreateInfoin itspNextchain, in addition to being required to have a non-nullpNextmember.This was not correctly handled by the generated code because
Vk*PipelineCreateInfostructures don't have thestructextendsflag set in the Vulkan registry. This commit aims at fixing that by blacklisting this structure and writing the encoder/decoders manually.Ideally, this should be solved in the codegen by not considering only structs with the
structextendsflag as possible encounters in apNextchain