Fix physical device discovery at replay time #2627
Conversation
|
CI gfxreconstruct build queued with queue ID 632169. |
|
CI gfxreconstruct build # 8694 running. |
|
CI gfxreconstruct build # 8694 passed. |
|
I could detect the bug with TraceToolTest But it was not deterministic and would succeed/fail depending on the device tested. I t can still be a good base to write a test, |
|
I will still try to come up with a better matching between newly enumerated physical devices and the existing ones in the vulkan object info table. |
marius-pelegrin-arm
force-pushed
the
fix-device-enumeration-override
branch
from
c0d1c0e to
3b237f4
Compare
|
Here you go, I copy the |
When the captured application enumerates physical devices multiple times, the `VulkanPhysicalDeviceInfo` instances get overwritten as many times in the table. This leads to data acquired after the enumeration to be lost because the `VulkanPhysicalDeviceInfo` instances are not copied before being overwritten. This is what this commit attempts to fix. Change-Id: I3238b30fd3bb1283d6b375499e61dbec10e18b05
MarkY-LunarG
force-pushed
the
fix-device-enumeration-override
branch
from
3b237f4 to
271e526
Compare
|
CI gfxreconstruct build queued with queue ID 634806. |
|
CI gfxreconstruct build # 8732 running. |
|
CI gfxreconstruct build # 8732 passed. |
MarkY-LunarG
left a comment
MarkY-LunarG
left a comment
There was a problem hiding this comment.
LGTM. Small request, just put a GFXRECON_LOG_DEBUG in the replace section saying "replacing x with y". Just so we can work backwards if there are issues.
Change-Id: I8ea7f5450af18e4f1359df66fbed8ffa41e334d0
|
CI gfxreconstruct build queued with queue ID 635611. |
|
CI gfxreconstruct build # 8741 running. |
|
CI gfxreconstruct build # 8741 passed. |
Done =) |
|
CI gfxreconstruct build queued with queue ID 636134. |
|
CI gfxreconstruct build # 8748 running. |
|
CI gfxreconstruct build # 8748 passed. |
|
I've started to repro the error internally again and I don't have time to investigate the issue for now, I will convert this ticket to draft and reopen it later. |
marius-pelegrin-arm
force-pushed
the
fix-device-enumeration-override
branch
from
30e4c52 to
2f8af7f
Compare
|
CI gfxreconstruct build # 8741 passed. |
3 participants
When the captured application enumerates physical devices multiple times, the
VulkanPhysicalDeviceInfoinstances get overwritten as many times in the table.This leads to data acquired after the enumeration to be lost because the
VulkanPhysicalDeviceInfoinstances are not copied before being overwritten.This is what this commit attempts to fix.