Two small fixes for quite once all trim ranges have been captured#1271
Merged
panos-lunarg merged 1 commit intoLunarG:devfrom Sep 26, 2023
Merged
Conversation
delete_instance_func_ should be set to nullptr when CaptureManager::DestroyInstance is called since functions register with std::atexit() will be called even when the process is terminated normally (when main returns) Also a few small ammends in the relevant documentation
Collaborator
|
CI gfxreconstruct build queued with queue ID 47857. |
Collaborator
|
CI gfxreconstruct build # 3247 running. |
Collaborator
|
CI gfxreconstruct build # 3247 passed. |
bradgrantham-lunarg
approved these changes
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delete_instance_func_ should be set to nullptr when CaptureManager::DestroyInstance is called since functions register with std::atexit() will be called even when the process is terminated normally (when main returns)
Also a few small ammends in the relevant documentation