Skip to content

Fix health and info endpoints when multiple LitAPIs are specified #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 5, 2025
Merged

Fix health and info endpoints when multiple LitAPIs are specified #529

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
98da817
Fix health and info endpoints when multiple LitAPIs are specified
vrdn-23 Jun 5, 2025
c8c3186
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 5, 2025
edfd29e
Fix tests
vrdn-23 Jun 5, 2025
7a2d487
Merge remote-tracking branch 'origin/vidamoda/health-endpoint-fix' in…
vrdn-23 Jun 5, 2025
0561ab4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 5, 2025
f4550a7
Apply suggestions from code review
aniketmaurya Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/litserve/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,22 +662,24 @@ async def health(request: Request) -> Response:
if not workers_ready:
workers_ready = all(v == WorkerSetupStatus.READY for v in self.workers_setup_status.values())

lit_api_health_status = self.lit_api.health()
api_list = self.lit_api if isinstance(self.lit_api, list) else [self.lit_api]
lit_api_health_status = all(lit_api.health() for lit_api in api_list)
if workers_ready and lit_api_health_status:
return Response(content="ok", status_code=200)

return Response(content="not ready", status_code=503)

@self.app.get(self.info_path, dependencies=[Depends(self.setup_auth())])
async def info(request: Request) -> Response:
api_list = self.lit_api if isinstance(self.lit_api, list) else [self.lit_api]
return JSONResponse(
content={
"model": self.model_metadata,
"server": {
"devices": self.devices,
"workers_per_device": self.workers_per_device,
"timeout": self.timeout,
"stream": self.lit_api.stream,
"stream": {lit_api.api_path: lit_api.stream for lit_api in api_list},
"max_payload_size": self.max_payload_size,
"track_requests": self.track_requests,
},
Expand Down
4 changes: 2 additions & 2 deletions tests/test_lit_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ def test_custom_info_path():
"devices": ["cpu"],
"workers_per_device": 1,
"timeout": 30,
"stream": False,
"stream": {"/predict": False},
"max_payload_size": None,
"track_requests": False,
},
Expand All @@ -460,7 +460,7 @@ def test_info_route():
"devices": ["cpu"],
"workers_per_device": 1,
"timeout": 30,
"stream": False,
"stream": {"/predict": False},
"max_payload_size": None,
"track_requests": False,
},
Expand Down