-
Notifications
You must be signed in to change notification settings - Fork 254
Fix health and info endpoints when multiple LitAPIs are specified #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix health and info endpoints when multiple LitAPIs are specified #529
Conversation
for more information, see https://pre-commit.ci
|
This was just a first pass to fix the problem quickly. If there are alternate approaches that anyone has in mind, I am open to trying that |
…to vidamoda/health-endpoint-fix
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
===================================
Coverage 87% 87%
===================================
Files 37 37
Lines 2557 2557
===================================
Hits 2227 2227
Misses 330 330 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vrdn-23! great catch 🚀
requested some changes - let's use litapi_connector to iterate over the LitAPI/s
|
Thanks for the quick turnaround @aniketmaurya! Any reason the new version cut is in |
What does this PR do?
Fixes # (issue).
Before submitting
Currently when multiple LitAPIs are specified under the same server, the health and info checkpoints fail. This PR iterates over a list of LitAPIs when applicable.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
cc @aniketmaurya @bhimrazy