Skip to content

Conversation

@vrdn-23
Copy link
Contributor

@vrdn-23 vrdn-23 commented Jun 5, 2025

What does this PR do?

Fixes # (issue).

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

Currently when multiple LitAPIs are specified under the same server, the health and info checkpoints fail. This PR iterates over a list of LitAPIs when applicable.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

cc @aniketmaurya @bhimrazy

@vrdn-23
Copy link
Contributor Author

vrdn-23 commented Jun 5, 2025

This was just a first pass to fix the problem quickly. If there are alternate approaches that anyone has in mind, I am open to trying that

@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87%. Comparing base (7672379) to head (f4550a7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #529   +/-   ##
===================================
  Coverage    87%    87%           
===================================
  Files        37     37           
  Lines      2557   2557           
===================================
  Hits       2227   2227           
  Misses      330    330           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@bhimrazy bhimrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vrdn-23! great catch 🚀

requested some changes - let's use litapi_connector to iterate over the LitAPI/s

@aniketmaurya aniketmaurya merged commit d41dd50 into Lightning-AI:main Jun 5, 2025
21 checks passed
@vrdn-23
Copy link
Contributor Author

vrdn-23 commented Jun 5, 2025

Thanks for the quick turnaround @aniketmaurya! Any reason the new version cut is in pre-release and not fully published? The current latest version is going to be unusable in k8s deployments when using multiple APIs, because the health check will keep on failing. Might be helpful to cut an actual release unless there is something else we're waiting on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants