use electron-build notarize config - #5635
Merged
filfreire merged 4 commits intoJan 12, 2023
Merged
Conversation
filfreire
force-pushed
the
build/use-electron-builder-notarize
branch
2 times, most recently
from
January 11, 2023 10:20
cbc5fd1 to
dc78271
Compare
filfreire
approved these changes
Jan 12, 2023
filfreire
force-pushed
the
build/use-electron-builder-notarize
branch
from
January 12, 2023 10:29
e2f1700 to
61af992
Compare
filfreire
enabled auto-merge (squash)
January 12, 2023 10:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog(Fixes): Fixed an issue (#5637) that prevented Snapcraft builds not working
Closes INS-2248, Related to #5633
Blocks fix for #5531 and #5637 that was originally done in #5555 - we can't use latest electron-builder yet with success
Related issues: electron-userland/electron-builder#7357 and Related PR: electron-userland/electron-builder#7361
Current status
spctlstep when notarizing - saying thedist/mac-universal/Insomnia.app file is not found - /Users/runner/work/***/***/packages/***/dist/mac-universal/Insomnia.app": No such file or directory- This should be fixed in fix: Remove spctl check from Mac's notarization electron-userland/electron-builder#7361TODO
npmRebuildto falseentitlementsInherit: './build/static/entitlements.mac.inherit.plist',next toentitlementsmacentry: