Skip to content

Commit 3765ad2

Browse files
jackkavfilfreire
andauthored
use electron-build notarize config (#5635)
* use electron-build notarize config * update electron-builder.config * Re-add snapcraft fix done in #5555 * update electron-builder Co-authored-by: Filipe Freire <livrofubia@gmail.com>
1 parent 08edada commit 3765ad2

5 files changed

Lines changed: 2392 additions & 2341 deletions

File tree

.github/workflows/release-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
env:
4545
NODE_OPTIONS: '--max_old_space_size=6144'
4646
APPLE_ID: ${{ matrix.os == 'macos-latest' && secrets.DESIGNER_APPLE_ID || '' }}
47-
APPLE_ID_PASSWORD: ${{ matrix.os == 'macos-latest' && secrets.DESIGNER_APPLE_ID_PASSWORD || '' }}
47+
APPLE_APP_SPECIFIC_PASSWORD: ${{ matrix.os == 'macos-latest' && secrets.DESIGNER_APPLE_ID_PASSWORD || '' }}
4848
CSC_LINK: ${{ matrix.csc_link_secret != '' && secrets[matrix.csc_link_secret] || '' }}
4949
CSC_KEY_PASSWORD: ${{ matrix.csc_key_password_secret != '' && secrets[matrix.csc_key_password_secret] || '' }}
5050

packages/insomnia/electron-builder.config.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ const BINARY_PREFIX = 'Insomnia.Core';
88
* @see https://www.electron.build/configuration/configuration
99
*/
1010
const config = {
11+
npmRebuild: false,
1112
appId: 'com.insomnia.app',
1213
protocols: [
1314
{
@@ -25,7 +26,6 @@ const config = {
2526
'./package.json',
2627
],
2728
publish: null,
28-
afterSign: './scripts/afterSignHook.js',
2929
extraResources: [
3030
{
3131
from: './bin',
@@ -46,6 +46,7 @@ const config = {
4646
hardenedRuntime: true,
4747
category: 'public.app-category.developer-tools',
4848
entitlements: './build/static/entitlements.mac.inherit.plist',
49+
entitlementsInherit: './build/static/entitlements.mac.inherit.plist',
4950
artifactName: `${BINARY_PREFIX}-\${version}.\${ext}`,
5051
target: [
5152
{
@@ -60,6 +61,12 @@ const config = {
6061
extendInfo: {
6162
NSRequiresAquaSystemAppearance: false,
6263
},
64+
notarize: {
65+
appBundleId: 'com.insomnia.app',
66+
},
67+
asarUnpack: [
68+
'node_modules/@getinsomnia/node-libcurl',
69+
],
6370
},
6471
dmg: {
6572
window: {
@@ -126,6 +133,9 @@ const config = {
126133
},
127134
],
128135
},
136+
snap: {
137+
base: 'core22',
138+
},
129139
};
130140

131141
const { env: { BUILD_TARGETS }, platform } = process;

0 commit comments

Comments
 (0)