Skip to content

Conversation

@chris-1243
Copy link
Contributor

Following request in PR #10793, Child lock is now enabled for software build 2.4.4 or higher. This was tested only with the E2204. I could not test this on E2206.

I have reached my typescript knowledge for the led enable option. If someone is able to help here and as suggested in the comment below, it would be great.

#10793 (comment)

CC: @andrei-lazarov

@andrei-lazarov
Copy link
Contributor

andrei-lazarov commented Dec 26, 2025

Thank you!
We can merge this, but I think I'll remove the version check for child lock entirely, as it works for all versions.
I'll figure out the LED too and make a PR once I confirm it

@chris-1243
Copy link
Contributor Author

chris-1243 commented Dec 26, 2025

Do you have an E2206 to test with ?

If firmware build 2.4.4 for both (E2204/E2206) is the minimum version and Child_lock is working, the firmware check codes should be removed.

@andrei-lazarov
Copy link
Contributor

andrei-lazarov commented Dec 26, 2025

No, my E2206 is already updated. Can only test 2.4.4 on E2204.
I understand now why you kept the check 🙂

@Koenkk Koenkk merged commit fb881fc into Koenkk:master Dec 27, 2025
3 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Dec 27, 2025

Thanks!

@chris-1243
Copy link
Contributor Author

@andrei-lazarov I just had a quick check and it seems the E2206 has been released after the E2204. In my opinion, the firmware check on the Child_lock option may be removed. What do you think ?

@andrei-lazarov
Copy link
Contributor

@chris-1243 I see the initial E2206 support request reports firmware: 2.4.34 - 20240215.
Date matches my updated E2204: 2.4.25 - 20240215
I agree, I'll try to make the LED PR tonight and also remove the version check for child_lock.

@chris-1243
Copy link
Contributor Author

If you remove the whole if statement

...
        result.exposes = [
            (device) => {
                if (
                    !isDummyDevice(device) &&
                    device.softwareBuildID &&
                    semverValid(device.softwareBuildID) &&
                    semverGte(device.softwareBuildID, "2.4.25")
                ) {
                    return [binary(resultName, access.ALL, "TRUE", "FALSE").withDescription(resultDescription).withCategory("config")];
                }
                return [];
            },
        ];

        return result;
    },

And you go as below, it should work.

...
        result.exposes = [
            (device) => {
                return [binary(resultName, access.ALL, "LOCK", "UNLOCK").withDescription(resultDescription).withCategory("config")];
            },
        ];

        return result;
    },

Of course, there might be a cleanest way...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants