Skip to content

Fix PHP 8.4 deprecations #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnito-org wants to merge 2 commits into from
Closed

Fix PHP 8.4 deprecations #517

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bec89b
Fix PHP 8.4 deprecations
gnito-org Dec 26, 2024
dad3a39
Revert wrong changes
gnito-org Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Knp/Snappy/AbstractGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ abstract class AbstractGenerator implements GeneratorInterface, LoggerAwareInter
* @param array $options
* @param null|array $env
*/
public function __construct($binary, array $options = [], array $env = null)
public function __construct($binary, array $options = [], ?array $env = null)
{
$this->configure();

Expand Down Expand Up @@ -380,7 +380,7 @@ abstract protected function configure();
*
* @return $this
*/
protected function addOption($name, $default = null)
protected function addOption($name, ?$default = null)
Copy link

@xabbuh xabbuh Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change needs to be reverted.

Copy link
Author

@gnito-org gnito-org Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand. Why does it need to be reverted?

Copy link
Author

@gnito-org gnito-org Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I rectified the error. Typical gnito fault.

{
if (\array_key_exists($name, $this->options)) {
throw new InvalidArgumentException(\sprintf('The option \'%s\' already exists.', $name));
Expand Down Expand Up @@ -483,7 +483,7 @@ protected function checkProcessStatus($status, $stdout, $stderr, $command)
*
* @return string The filename
*/
protected function createTemporaryFile($content = null, $extension = null)
protected function createTemporaryFile(?$content = null, ?$extension = null)
Copy link

@xabbuh xabbuh Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

{
$dir = \rtrim($this->getTemporaryFolder(), \DIRECTORY_SEPARATOR);

Expand Down
2 changes: 1 addition & 1 deletion src/Knp/Snappy/Image.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class Image extends AbstractGenerator
/**
* {@inheritdoc}
*/
public function __construct($binary = null, array $options = [], array $env = null)
public function __construct(?$binary = null, array $options = [], ?array $env = null)
Copy link

@xabbuh xabbuh Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function __construct(?$binary = null, array $options = [], ?array $env = null)
public function __construct($binary = null, array $options = [], ?array $env = null)

{
$this->setDefaultExtension('jpg');

Expand Down
2 changes: 1 addition & 1 deletion src/Knp/Snappy/Pdf.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class Pdf extends AbstractGenerator
/**
* {@inheritdoc}
*/
public function __construct($binary = null, array $options = [], array $env = null)
public function __construct(?$binary = null, array $options = [], ?array $env = null)
{
$this->setDefaultExtension('pdf');
$this->setOptionsWithContentCheck();
Expand Down