Fix PHP 8.4 deprecations #517
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
suggested changes
Dec 26, 2024
src/Knp/Snappy/AbstractGenerator.php
Outdated
| * @return $this | ||
| */ | ||
| protected function addOption($name, $default = null) | ||
| protected function addOption($name, ?$default = null) |
Author
There was a problem hiding this comment.
I do not understand. Why does it need to be reverted?
Author
There was a problem hiding this comment.
Nevermind, I rectified the error. Typical gnito fault.
src/Knp/Snappy/AbstractGenerator.php
Outdated
| * @return string The filename | ||
| */ | ||
| protected function createTemporaryFile($content = null, $extension = null) | ||
| protected function createTemporaryFile(?$content = null, ?$extension = null) |
src/Knp/Snappy/Image.php
Outdated
| * {@inheritdoc} | ||
| */ | ||
| public function __construct($binary = null, array $options = [], array $env = null) | ||
| public function __construct(?$binary = null, array $options = [], ?array $env = null) |
There was a problem hiding this comment.
Suggested change
| public function __construct(?$binary = null, array $options = [], ?array $env = null) | |
| public function __construct($binary = null, array $options = [], ?array $env = null) |
|
now this is basically the same as #515 |
Author
|
I will close my PR when either one gets merged. |
Contributor
|
Duplicate of #515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.