Added basic support for IconSource and its subclasses#192
Added basic support for IconSource and its subclasses#192Kinnara merged 4 commits intoKinnara:masterfrom ShankarBUS:IconSource
Conversation
|
Should I also add the xml documentation comments? |
|
Hey @Kinnara, I explored ModernWpf's source code. This increases the inconsistency in code between WinUI and ModernWpf. What I suggest you is to take a look at our toolkit and see how it handles this scenario. I've made a This will help us to reduce extra code and increase the consistency between the codebases. My workaround is imperfect but with your help, we can improve it. What do you say? |
and moved code into an existing file to resolved CS0436 warning
|
@Kinnara, all done! This PR is ready to be merged. |
The main road block is that we have to call |
|
We have to unregister the callbacks when unloading the control. https://stackoverflow.com/a/45160026 This behaviour is same in WinRT, isn't it. I've a little experience porting Controls from WCT so I can confirm they do the callbacks unregistering on unload. If you say so, it must correct be correct 🤷♂️. Thanks for merging this PR! |
Fixes #191