Bump DPC++ and hipSYCL versions used for CI #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to be able to bump a container's version as part of a PR but without disrupting CI on other branches, we have to include the version in the container image tag. A downside that comes with this is that we now need to manually keep the versions in sync between the two workflows. Since the ComputeCpp DockerHub repository has not been updated to use versioned tags, we don't specify a version for ComputeCpp for the time being.
DPC++ to 1f3f9b9 (December 19) hipSYCL to b836149 (December 9)
This adds two new categories (exceptions, opencl_interop) to the list of tests that do not compile with DPC++. However, serveral tests that DO compile are not being removed due to compile time concerns (which will be addressed in a separate change). The following tests could be removed from the DPC++ CI filter: - accessor - atomic - handler - hierarchical - id - invoke - item - math_builtin_api - multi_ptr - nd_item - range - specialization_constants
psalz
requested review from
ProGTX,
bader,
illuhad and
keryell
as code owners
This was referenced Dec 20, 2021
bader
approved these changes
Dec 21, 2021
Contributor
Author
|
Not sure why the status checks aren't updating but since CI has passed for all three implementations I will just go ahead an merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes both #234 and #240.
Changes compared to #234:
(Note that CI will fail on this initially since the new container for DPC++ is still building, need to re-run checks after that).