Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Dec 20, 2021

I wish to remove the usm tests from the exclude list for
DPCPP and this requires using DPCPP with support for
the sycl::atomic_ref class template. So, the version of
the DPCPP compiler should be upgraded.

Signed-off-by: Pavel Samolysov [email protected]

I wish to remove the usm tests from the exclude list for
DPCPP and this requires using DPCPP with support for
the sycl::atomic_ref class template. So the version of
the DPCPP compiler should be upgraded.

Signed-off-by: Pavel Samolysov <[email protected]>
@ghost ghost requested review from ProGTX, bader, illuhad and keryell as code owners December 20, 2021 10:49
@bader bader requested a review from psalz December 20, 2021 10:54
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
FYI, it interferes with #234, which bumps DPC++ version among other things.

@ghost
Copy link
Author

ghost commented Dec 20, 2021

@bader Thank you for the information. @psalz could you have a look too?

@psalz
Copy link
Contributor

psalz commented Dec 20, 2021

The current process for updating CI container image versions is somewhat flawed in that the PR itself does not get checked with the new version. If we had merged this PR directly, future CI runs would have failed since with newer versions of DPC++ two additional test categories (exceptions and opencl_interop) fail to compile (while several additional categories do now compile). This is something I tried to address in #234 by introducing versioned image tags, but we ran into some trouble with long compilation times and ComputeCpp.

Anyway, I've opened a new PR #241 that introduces versioned image tags while now also bumping DPC++ to the version you are suggesting here (1f3f9b9), and adding the failing categories to the filter. I'll therefore go ahead and close this PR!

@psalz psalz closed this Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants