Remove WebGPU support #4108
Remove WebGPU support #4108
Conversation
Leaves SPV_ENV_WEBGPU_0 enum in place, but marked deprecated, so users of the library are not broken by an API enum being removed. Fixes #4101
|
PTAL, the shaderc-smoketest failure appears to be some gtest weirdness unrelated to my patch. |
alan-baker
left a comment
alan-baker
left a comment
There was a problem hiding this comment.
For the command line tools at least it might make sense to issue an error if --target-env=webgpu is used. It seems to assert in debug, but a clear error would be more helpful.
webgpu0 was the old string and it using it for '--target-env=' give the following error: Are you wanting a more specific error about WebGPU no longer being implemented or is that sufficient? |
No, that's good. I guess I missed that. |
* Deprecate WebGPU SPIRV support Roll third_party/spirv-tools/ 1bb80d2..ee39b5d (16 commits) KhronosGroup/SPIRV-Tools@1bb80d2...ee39b5d $ git log 1bb80d2..ee39b5d --date=short --no-merges --format='%ad %ae %s' 2021-01-15 46493288+sfricke-samsung spirv-val: Add Vulkan Addressing Model check (KhronosGroup#4107) 2021-01-14 rharrison Remove WebGPU support (KhronosGroup#4108) 2021-01-14 46493288+sfricke-samsung spirv-val: Vulkan atomic storage class (KhronosGroup#4079) 2021-01-13 jaebaek Avoid integrity check failures caused by propagating line instructions (KhronosGroup#4096) 2021-01-13 pierremoreau Linker usability improvements (KhronosGroup#4084) 2021-01-12 dj2 Revert "Generate differentiated error codes for buffer oob checking (KhronosGroup#4097)" (KhronosGroup#4100) 2021-01-11 greg Generate differentiated error codes for buffer oob checking (KhronosGroup#4097) 2021-01-07 dneto use std::string::empty() to test for emptiness (KhronosGroup#4098) 2021-01-07 46493288+sfricke-samsung spirv-val: Label standalone Vulkan VUID (KhronosGroup#4091) 2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan decroation VUID (KhronosGroup#4090) 2021-01-06 stevenperron Fix binding number calculation in desc sroa (KhronosGroup#4095) 2021-01-06 stevenperron Build deps: dump ini from 1.3.5 to 1.3.7 in tools/sva (KhronosGroup#4092) 2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan FP Mode VUID (KhronosGroup#4088) 2021-01-06 46493288+sfricke-samsung spirv-val: Fix Vulkan image sampled check (KhronosGroup#4085) 2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan ForwardPointer VUID (KhronosGroup#4089) 2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan ImageTexelPointer format check (KhronosGroup#4087) Created with: roll-dep third_party/spirv-tools Fixes KhronosGroup#1166 * Retain the public API enums * Fix implicit fallthrough
2 participants
Leaves SPV_ENV_WEBGPU_0 enum in place, but marked deprecated, so users
of the library are not broken by an API enum being removed.
Fixes #4101