spirv-val: Add Vulkan Addressing Model check #4107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-baker
approved these changes
Jan 15, 2021
dneto0
pushed a commit
to dneto0/SPIRV-Tools
that referenced
this pull request
Sep 14, 2024
* Deprecate WebGPU SPIRV support Roll third_party/spirv-tools/ 1bb80d2..ee39b5d (16 commits) KhronosGroup/SPIRV-Tools@1bb80d2...ee39b5d $ git log 1bb80d2..ee39b5d --date=short --no-merges --format='%ad %ae %s' 2021-01-15 46493288+sfricke-samsung spirv-val: Add Vulkan Addressing Model check (KhronosGroup#4107) 2021-01-14 rharrison Remove WebGPU support (KhronosGroup#4108) 2021-01-14 46493288+sfricke-samsung spirv-val: Vulkan atomic storage class (KhronosGroup#4079) 2021-01-13 jaebaek Avoid integrity check failures caused by propagating line instructions (KhronosGroup#4096) 2021-01-13 pierremoreau Linker usability improvements (KhronosGroup#4084) 2021-01-12 dj2 Revert "Generate differentiated error codes for buffer oob checking (KhronosGroup#4097)" (KhronosGroup#4100) 2021-01-11 greg Generate differentiated error codes for buffer oob checking (KhronosGroup#4097) 2021-01-07 dneto use std::string::empty() to test for emptiness (KhronosGroup#4098) 2021-01-07 46493288+sfricke-samsung spirv-val: Label standalone Vulkan VUID (KhronosGroup#4091) 2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan decroation VUID (KhronosGroup#4090) 2021-01-06 stevenperron Fix binding number calculation in desc sroa (KhronosGroup#4095) 2021-01-06 stevenperron Build deps: dump ini from 1.3.5 to 1.3.7 in tools/sva (KhronosGroup#4092) 2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan FP Mode VUID (KhronosGroup#4088) 2021-01-06 46493288+sfricke-samsung spirv-val: Fix Vulkan image sampled check (KhronosGroup#4085) 2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan ForwardPointer VUID (KhronosGroup#4089) 2021-01-06 46493288+sfricke-samsung spirv-val: Add Vulkan ImageTexelPointer format check (KhronosGroup#4087) Created with: roll-dep third_party/spirv-tools Fixes KhronosGroup#1166 * Retain the public API enums * Fix implicit fallthrough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried writing a negative test, but the issue is the only invalid addressing models currently are Physical32/64 which both need the
Addressescapability and it will hit that error firstAdding for future-proofing if a Non-Vulkan API adds a new addressing model
Also covers
VUID-StandaloneSpirv-None-04635