Add test coverage for MediaPickerConfigSerializer v13 migration logic#875
Merged
KevinJump merged 2 commits intov17/picker-migrationsfrom Jan 9, 2026
Merged
Add test coverage for MediaPickerConfigSerializer v13 migration logic#875KevinJump merged 2 commits intov17/picker-migrationsfrom
KevinJump merged 2 commits intov17/picker-migrationsfrom
Conversation
Co-authored-by: KevinJump <[email protected]>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] WIP address feedback on filter and startnodeid migration
Add test coverage for MediaPickerConfigSerializer v13 migration logic
Jan 9, 2026
KevinJump
approved these changes
Jan 9, 2026
KevinJump
added a commit
that referenced
this pull request
Jan 12, 2026
#873) * Fix: #870 - Migrate Filter and StartNodeId values for pickers from v13 * Update uSync.Core/DataTypes/PickerConfigurationSerializerBase.cs Co-authored-by: Copilot <[email protected]> * Update uSync.Core/DataTypes/PickerConfigurationSerializerBase.cs Co-authored-by: Copilot <[email protected]> * Update uSync.Core/Mapping/Mappers/MediaPicker3Mapper.cs Co-authored-by: Copilot <[email protected]> * Update uSync.Core/DataTypes/PickerConfigurationSerializerBase.cs Co-authored-by: Copilot <[email protected]> * revert mapper service injection (not required) * Add test coverage for MediaPickerConfigSerializer v13 migration logic (#875) * Initial plan * Add MediaPickerMigrationTests to cover Filter and StartNodeId migrations Co-authored-by: KevinJump <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: KevinJump <[email protected]> * Add migration tests for ContentPicker and MediaPicker configuration serializers (#874) * Initial plan * Add comprehensive migration tests for ContentPicker and MediaPicker configurations Co-authored-by: KevinJump <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: KevinJump <[email protected]> Co-authored-by: Kevin Jump <[email protected]> * fixup richtext tst --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: KevinJump <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on #873 requesting test coverage for the MediaPickerConfigSerializer migration logic that converts v13 configuration formats to v14.
Changes
MediaPickerMigrationTests.csfollowing existing migration test patterns"Image,Video"→"cc07b313-...,f6c515bb-...")"umb://media/71332aa7..."→"71332aa7-8bea-...")Uses Moq to stub
IMediaTypeServicewith test media types, consistent withListMigrationTestsandRichTextMigrationTestspatterns.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.