Skip to content

Conversation

@KendallDoesCoding
Copy link
Owner

🛠️ Fixes Issue

Related Issue/Addition to code

  • I think a preloader is needed as sometimes the background glitches and takes a long time to load, also the bug as discussed, that the songs don't show for 1-2 seconds is resolved.

Although, the issue with this is that users may not like being on the load screen/it may make users go away from the site.

👨‍💻 Changes proposed

  • add preloader in the main and ludsocials directory

Type of change

  • New feature (non-breaking change which adds functionality)

📄 Note to reviewers

What do you think about this @TechStudent11?

@netlify
Copy link

netlify bot commented Apr 17, 2022

Deploy Preview for mogulchristmas ready!

Name Link
🔨 Latest commit 7ccac3a
🔍 Latest deploy log https://app.netlify.com/sites/mogulchristmas/deploys/625c6737f76aed00096850dc
😎 Deploy Preview https://deploy-preview-284--mogulchristmas.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@KendallDoesCoding KendallDoesCoding self-assigned this Apr 17, 2022
@KendallDoesCoding KendallDoesCoding added javascript Javascript PR or a Javascript related issue with code. html HTML PR or a HTML related issue with code. css CSS PR or a CSS related issue with code. labels Apr 17, 2022
@TechStudent10
Copy link
Collaborator

Hm? I do not get the point of this.

@KendallDoesCoding
Copy link
Owner Author

Hm? I do not get the point of this.

This is basically to load the full site and then after the animation goes the site fully loaded shows, otherwise depending on your internet connection it takes ages to load the site.

@TechStudent10
Copy link
Collaborator

Ah okay

Copy link
Collaborator

@TechStudent10 TechStudent10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a fade instead of cutting directly to the site.

@KendallDoesCoding
Copy link
Owner Author

I would add a fade instead of cutting directly to the site.

Good idea, I need to learn how to do this lol.

@KendallDoesCoding KendallDoesCoding marked this pull request as draft May 4, 2022 11:20
@KendallDoesCoding
Copy link
Owner Author

On second thought, a preloader isn't needed for NOW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css CSS PR or a CSS related issue with code. html HTML PR or a HTML related issue with code. javascript Javascript PR or a Javascript related issue with code. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants