Skip to content

Conversation

@KendallDoesCoding
Copy link
Owner

🛠️ Fixes Issue

Related Issue/Addition to code

  • I think a preloader is needed as sometimes the background glitches and takes a long time to load, also the bug as discussed, that the songs don't show for 1-2 seconds is resolved.

Although, the issue with this is that users may not like being on the load screen/it may make users go away from the site.

👨‍💻 Changes proposed

  • add preloader in the main and ludsocials directory

Type of change

  • New feature (non-breaking change which adds functionality)

📄 Note to reviewers

What do you think about this @TechStudent11?

@KendallDoesCoding KendallDoesCoding added enhancement New feature or request javascript Javascript PR or a Javascript related issue with code. html HTML PR or a HTML related issue with code. css CSS PR or a CSS related issue with code. labels Apr 17, 2022
@KendallDoesCoding KendallDoesCoding self-assigned this Apr 17, 2022
@netlify
Copy link

netlify bot commented Apr 17, 2022

Deploy Preview for mogulchristmas ready!

Name Link
🔨 Latest commit ae5494f
🔍 Latest deploy log https://app.netlify.com/sites/mogulchristmas/deploys/625c15e9ce96780008e15a2d
😎 Deploy Preview https://deploy-preview-282--mogulchristmas.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@KendallDoesCoding KendallDoesCoding merged commit 43b86b2 into main Apr 17, 2022
@KendallDoesCoding KendallDoesCoding deleted the preloader branch April 17, 2022 13:31
@KendallDoesCoding
Copy link
Owner Author

lol, git is weird bro

@KendallDoesCoding KendallDoesCoding restored the preloader branch April 17, 2022 13:39
width: 100%;
position: fixed;
z-index: 100;
position: fixed;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[stylelint] Unexpected duplicate "position" (view)

Rule Severity
declaration-block-no-duplicate-properties error

References:

You can close this issue if no need to fix it. Learn more.

duplicate

@KendallDoesCoding
Copy link
Owner Author

**NEW PR: #284 **

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css CSS PR or a CSS related issue with code. enhancement New feature or request html HTML PR or a HTML related issue with code. javascript Javascript PR or a Javascript related issue with code. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants