fix consistency of trimtrailingzeros (Ryu) #40685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hmmm, the linux64/macos64 builds are failing because working directory is dirty? Something about some SuiteSparse files? Anyone know what's going on w/ that? cc: @staticfloat @ViralBShah |
quinnj
approved these changes
May 3, 2021
Member
|
@IanButterworth did this in #40688. Maybe just rebase to master? |
Member
Author
|
Rebased. Now it's fine. |
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* fix consistency of trimtrailingzeros (Ryu)
dghosef
pushed a commit
to dghosef/julia
that referenced
this pull request
May 11, 2021
* fix consistency of trimtrailingzeros (Ryu)
KristofferC
pushed a commit
that referenced
this pull request
May 11, 2021
* fix consistency of trimtrailingzeros (Ryu) (cherry picked from commit ff213c1)
45 tasks
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
* fix consistency of trimtrailingzeros (Ryu)
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
* fix consistency of trimtrailingzeros (Ryu) (cherry picked from commit ff213c1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that
Ryu.writefixedwithtrimtrailingzeros = true(the last argument) does not trim trailing zeros if the given value is zero:There may be a reason for this behavior, but I think it is inconsistent. This PR fixes that.