Skip to content

Commit 44d1ab5

Browse files
committed
fix writeexp and test
1 parent 6801cb8 commit 44d1ab5

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

base/ryu/exp.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ function writeexp(buf, pos, v::T,
1010
if x == 0
1111
buf[pos] = UInt8('0')
1212
pos += 1
13-
if precision > 0
13+
if precision > 0 && !trimtrailingzeros
1414
buf[pos] = decchar
1515
pos += 1
1616
for _ = 1:precision

test/ryu.jl

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -545,9 +545,9 @@ end # Float16
545545
end
546546

547547
@testset "Consistency of trimtrailingzeros" begin
548-
Ryu.writefixed(0.0, 1, false, false, false, UInt8('.'), true) == "0"
549-
Ryu.writefixed(1.0, 1, false, false, false, UInt8('.'), true) == "1"
550-
Ryu.writefixed(2.0, 1, false, false, false, UInt8('.'), true) == "2"
548+
@test Ryu.writefixed(0.0, 1, false, false, false, UInt8('.'), true) == "0"
549+
@test Ryu.writefixed(1.0, 1, false, false, false, UInt8('.'), true) == "1"
550+
@test Ryu.writefixed(2.0, 1, false, false, false, UInt8('.'), true) == "2"
551551
end
552552
end # fixed
553553

@@ -741,6 +741,12 @@ end
741741
@test Ryu.writeexp(1e+83, 1) == "1.0e+83"
742742
end
743743

744+
@testset "Consistency of trimtrailingzeros" begin
745+
@test Ryu.writeexp(0.0, 1, false, false, false, UInt8('e'), UInt8('.'), true) == "0e+00"
746+
@test Ryu.writeexp(1.0, 1, false, false, false, UInt8('e'), UInt8('.'), true) == "1e+00"
747+
@test Ryu.writeexp(2.0, 1, false, false, false, UInt8('e'), UInt8('.'), true) == "2e+00"
748+
end
749+
744750
end # exp
745751

746752
@testset "compact" begin

0 commit comments

Comments
 (0)