Skip to content

add spzeros(::Tuple{<:Integer}) #40515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkarrasch merged 5 commits into from
Apr 18, 2021
Merged

add spzeros(::Tuple{<:Integer}) #40515

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a36aedf
add spzeros(::Tuple{<Integer})
abraunst Apr 17, 2021
e19e8d8
implement spzeros(Tv, (n,)) and spzeros(Ti, Tv, (n,))
abraunst Apr 17, 2021
251be42
add tests for spzeros
abraunst Apr 17, 2021
11658fe
fix test
abraunst Apr 18, 2021
2701d85
Test `Int16` instead of `Int`
abraunst Apr 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions stdlib/SparseArrays/src/sparsevector.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,11 @@ Base.unaliascopy(S::SparseVector) = typeof(S)(length(S), unaliascopy(nonzeroinds
### Construct empty sparse vector

spzeros(len::Integer) = spzeros(Float64, len)
spzeros(dims::Tuple{<:Integer}) = spzeros(Float64, dims[1])
spzeros(::Type{T}, len::Integer) where {T} = SparseVector(len, Int[], T[])
spzeros(::Type{T}, dims::Tuple{<:Integer}) where {T} = spzeros(T, dims[1])
spzeros(::Type{Tv}, ::Type{Ti}, len::Integer) where {Tv,Ti<:Integer} = SparseVector(len, Ti[], Tv[])
spzeros(::Type{Tv}, ::Type{Ti}, dims::Tuple{<:Integer}) where {Tv,Ti<:Integer} = spzeros(Tv, Ti, dims[1])

LinearAlgebra.fillstored!(x::SparseVector, y) = (fill!(nonzeros(x), y); x)

Expand Down
6 changes: 5 additions & 1 deletion stdlib/SparseArrays/test/sparsevector.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,11 @@ end
@testset "other constructors" begin
# construct empty sparse vector

@test exact_equal(spzeros(Float64, 8), SparseVector(8, Int[], Float64[]))
for dims in (8, (8,))
@test exact_equal(spzeros(dims), SparseVector(8, Int[], Float64[]))
@test exact_equal(spzeros(Float64, dims), SparseVector(8, Int[], Float64[]))
@test exact_equal(spzeros(Float64, Int, dims), SparseVector(8, Int[], Float64[]))
end

@testset "from list of indices and values" begin
@test exact_equal(
Expand Down