Skip to content

add spzeros(::Tuple{<:Integer}) #40515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkarrasch merged 5 commits into from
Apr 18, 2021
Merged

add spzeros(::Tuple{<:Integer}) #40515

dkarrasch merged 5 commits into from
Apr 18, 2021

Conversation

@abraunst
Copy link
Contributor

@abraunst abraunst commented Apr 17, 2021 •
edited
Loading

Fixes #40505

@abraunst abraunst changed the title add spzeros(::Tuple{<Integer}) add spzeros(::Tuple{<:Integer}) Apr 17, 2021
@dkarrasch
Copy link
Member

dkarrasch commented Apr 17, 2021

Shall we have a little test to make sure this "new functionality" doesn't regress?

@dkarrasch dkarrasch added the sparse Sparse arrays label Apr 17, 2021
@abraunst
Copy link
Contributor Author

abraunst commented Apr 17, 2021

Shall we have a little test to make sure this "new functionality" doesn't regress?

Sure

@abraunst
Copy link
Contributor Author

abraunst commented Apr 17, 2021

I added two more missing versions of spzeros with type parameters and dims and added some tests.

dkarrasch
dkarrasch reviewed Apr 18, 2021
View reviewed changes
@abraunst @dkarrasch
Test Int16 instead of Int
2701d85 
Co-authored-by: Daniel Karrasch <[email protected]>
@dkarrasch dkarrasch added the merge me PR is reviewed. Merge when all tests are passing label Apr 18, 2021
@abraunst
Copy link
Contributor Author

abraunst commented Apr 18, 2021

There are two errors in the commit messages 😓 (< instead of <: and a wrong order in type parameters). Should I rebase + squash + rewrite the commit message? Otherwise please correct or simplify the message when merging.

@dkarrasch
Copy link
Member

dkarrasch commented Apr 18, 2021

Typically, I delete all intermediate commit messages and only keep the PR title upon merging. So you still have a few minutes to update the title if you wish. 😉 But I don't think it's necessary IMHO.

@abraunst
Copy link
Contributor Author

abraunst commented Apr 18, 2021

Typically, I delete all intermediate commit messages and only keep the PR title upon merging. So you still have a few minutes to update the title if you wish. But I don't think it's necessary IMHO.

Thanks! The title is fine 👍

@dkarrasch dkarrasch merged commit 36a048c into JuliaLang:master Apr 18, 2021
@dkarrasch dkarrasch removed the merge me PR is reviewed. Merge when all tests are passing label Apr 18, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@abraunst @ElOceanografo
add spzeros(::Tuple{<:Integer}) (JuliaLang#40515)
d25a05d
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@abraunst @antoine-levitt
add spzeros(::Tuple{<:Integer}) (JuliaLang#40515)
e40fd42
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@abraunst @johanmon
add spzeros(::Tuple{<:Integer}) (JuliaLang#40515)
811719b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkarrasch dkarrasch dkarrasch approved these changes

Assignees

No one assigned

Labels

sparse Sparse arrays

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

spzeros((2,)) is not defined

2 participants

@abraunst @dkarrasch