RFC: process: make SIGPIPE an always failure #39574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
io
Member
Author
|
This reverts #1469, going back to the original design |
This error code does not exist on Windows, so any code that relied on this was broken (would fail this test) on that platform already. In most cases, it was actually a serious error too, such as `cp -v` or `tar -v`, which will indeed fail midway and give corrupt results if you do not read their output to completion!
vtjnash
force-pushed
the
jn/unsuccess-SIGPIPE
branch
from
0d93f06 to
be69068
Compare
Member
|
I, @StefanKarpinski, do hereby attest that I did actually tell @vtjnash that I was fine with this. |
simeonschaub
removed
the
merge me
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
This error code does not exist on Windows, so any code that relied on this was broken (would fail this test) on that platform already. In most cases, it was actually a serious error too, such as `cp -v` or `tar -v`, which will indeed fail midway and give corrupt results if you do not read their output to completion! Reverts JuliaLang#1469, in essence
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
This error code does not exist on Windows, so any code that relied on this was broken (would fail this test) on that platform already. In most cases, it was actually a serious error too, such as `cp -v` or `tar -v`, which will indeed fail midway and give corrupt results if you do not read their output to completion! Reverts JuliaLang#1469, in essence
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
This error code does not exist on Windows, so any code that relied on this was broken (would fail this test) on that platform already. In most cases, it was actually a serious error too, such as `cp -v` or `tar -v`, which will indeed fail midway and give corrupt results if you do not read their output to completion! Reverts JuliaLang#1469, in essence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error code does not exist on Windows, so any code that relied on
this was broken (would fail this test) on that platform already. In most
cases, it was actually a serious error too, such as
cp -vortar -v,which will indeed fail midway and give corrupt results if you do not read
their output to completion!
Therefore, while breaking for posix, I think this should be considered a bugfix.
Discovered while trying to fix the CI problems with AArch64/Tar/ArgTools (#39544).