fix definition of open I/O to Process #39544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
io
Keno
approved these changes
Feb 5, 2021
Member
Keno
left a comment
Keno
left a comment
There was a problem hiding this comment.
Semantics change is fine to me. Before we had this return Process this would close whichever stream the user requested rather than .in (which would correspond to whether you were expecting to read from or write to the process), so closing both seems fine.
Keno
added
the
minor change
Member
Author
|
Yeah, the problem apparently will be this is a hard-break for ArgTools / Tar tests, which rely on the existence of SIGPIPE being produced by |
This was referenced Feb 7, 2021
14 tasks
This was referenced Mar 23, 2021
45 tasks
Member
|
Should be ok to merge after #41059. |
vtjnash
added
merge me
It seems this behavior was relied upon in ArgTools, so we change the behavior here to match. This is probably more in line with what people expect (and if not, this makes the `success` check now fail noisily, instead of hanging the process)! Refs #38996
DilumAluthge
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that ArgTools exports a number of test scripts that depend on this change. This was causing many of the failures of the aarch64 buildbot. Hopefully nobody else was depending on the reverse, but I think that should be far less likely (and likely a bug elsewhere in their code already anyways).