Skip to content

Fix Project equality when compat entries are present #2826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IanButterworth merged 4 commits into from
Nov 7, 2021
Merged

Fix Project equality when compat entries are present #2826

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3891351
add project equality check including [compat] enntries
IanButterworth Nov 7, 2021
ddb602b
add Compat equality method
IanButterworth Nov 7, 2021
0142c07
only check Compat.val for equality
IanButterworth Nov 7, 2021
eb03830
also define hash
IanButterworth Nov 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Types.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ Base.@kwdef mutable struct Compat
val::VersionSpec
str::String
end
Base.:(==)(t1::Compat, t2::Compat) = all(x -> (getfield(t1, x) == getfield(t2, x))::Bool, fieldnames(Compat))

Base.@kwdef mutable struct Project
other::Dict{String,Any} = Dict{String,Any}()
Expand Down
1 change: 1 addition & 0 deletions test/new.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2409,6 +2409,7 @@ end
for property in propertynames(a)
@test getproperty(a, property) == getproperty(b, property)
end
@test a == b
end
rm(dirname(temp); recursive = true, force = true)
end
Expand Down
9 changes: 9 additions & 0 deletions test/project/good/withcompat.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
name = "FooBar"
uuid = "3644d252-e973-11e8-2189-c5f41ab12867"
version = "0.1.0"

[deps]
Example = "7876af07-990d-54b4-ab0e-23690620f79a"

[compat]
Example = "0.1"