-
-
Notifications
You must be signed in to change notification settings - Fork 285
Fix Project equality when compat entries are present #2826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Project equality when compat entries are present #2826
Conversation
|
PkgServer breakage has been fixed. |
|
Is this equality check used for something other than #2202 ? That PR didn't implement it so I guess so? Possibly another internal function should be used instead of overloading |
|
Sorry, I don't follow. I may be being slow though.. This PR specifically fixes a bug in the behavior introduced in #2202 where it will alway re-write a Project when compat fields are present. And because the equality check #2202 uses is just |
(cherry picked from commit 05d828d)
|
I don't think this applies to 1.6. |
The compat field of a Project appears to breaking equality even when the projects are identical.
This was observed in JuliaRegistries/General#47659 (comment) where an unchanged Project was being re-written to disk, without any actual changes to the file even though this check should prevent that
I'm adding the tests first to prove the problem exists first.
Also, @staticfloat the pkgserver tests are failing with