Skip to content

fall back to gcc/clang if g++/clang++ not avaiable, but warn about it #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2021
Merged

fall back to gcc/clang if g++/clang++ not avaiable, but warn about it #608

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f36fb3
fall back to gcc/clang if g++/clang++ not avaiable, but warn about it
KristofferC Oct 15, 2021
11f6f3b
fix error message
KristofferC Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions src/PackageCompiler.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ function march()
end
end

const warned_cpp_compiler = Ref{Bool}(false)

function run_compiler(cmd::Cmd; cplusplus::Bool=false)
cc = get(ENV, "JULIA_CC", nothing)
path = nothing
Expand All @@ -99,15 +101,33 @@ function run_compiler(cmd::Cmd; cplusplus::Bool=false)
compiler_cmd = Cmd(Base.shell_split(cc))
path = nothing
elseif !Sys.iswindows()
compilers_cpp = ("g++", "clang++")
compilers_c = ("gcc", "clang")
found_compiler = false
compilers = cplusplus ? ("g++", "clang++") : ("gcc", "clang")
for compiler in compilers
if Sys.which(compiler) !== nothing
compiler_cmd = `$compiler`
found_compiler = true
if cplusplus
for compiler in compilers_cpp
if Sys.which(compiler) !== nothing
compiler_cmd = `$compiler`
found_compiler = true
break
end
end
end
found_compiler || error("could not find a compiler, looked for ", join(compilers, " and "))
if !found_compiler
for compiler in compilers_c
if Sys.which(compiler) !== nothing
compiler_cmd = `$compiler`
found_compiler = true
if cplusplus && !warned_cpp_compiler[]
@warn "could not find a c++ compiler (g++ or clang++), falling back to $compiler, this might cause link errors"
warned_cpp_compiler[] = true
end
break
end
end
end
found_compiler || error("could not find a compiler, looked for ",
join(((cplusplus ? compilers_cpp : ())..., compilers_c...), ", ", " and "))
end
if path !== nothing
compiler_cmd = addenv(compiler_cmd, "PATH" => string(ENV["PATH"], ";", dirname(path)))
Expand Down