Skip to content

fall back to gcc/clang if g++/clang++ not avaiable, but warn about it #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2021
Merged

fall back to gcc/clang if g++/clang++ not avaiable, but warn about it #608

merged 2 commits into from
Oct 15, 2021

Conversation

@KristofferC
Copy link
Member

@KristofferC KristofferC commented Oct 15, 2021

Fixes #606

@KristofferC KristofferC mentioned this pull request Oct 15, 2021
Closed
@codecov
Copy link

codecov bot commented Oct 15, 2021 •
edited
Loading

Codecov Report

Merging #608 (11f6f3b) into master (ea6fb75) will decrease coverage by 0.13%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
- Coverage   88.64%   88.50%   -0.14%     
==========================================
  Files           2        2              
  Lines         449      461      +12     
==========================================
+ Hits          398      408      +10     
- Misses         51       53       +2
Impacted Files Coverage Δ
src/PackageCompiler.jl 88.36% <88.88%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea6fb75...11f6f3b. Read the comment docs.

mmiller-max
mmiller-max reviewed Oct 15, 2021
View reviewed changes
src/PackageCompiler.jl Outdated
end
end
end
found_compiler || error("could not find a compiler, looked for ", join(compilers, " and "))
Copy link

@mmiller-max mmiller-max Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compilers doesn't exist now

Copy link
Member Author

@KristofferC KristofferC Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch!

Copy link
Member Author

@KristofferC KristofferC Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed.

@mmiller-max
Copy link

mmiller-max commented Oct 15, 2021

Tested and fixes the issue 👍

@KristofferC KristofferC merged commit cded464 into master Oct 15, 2021
@KristofferC KristofferC deleted the kc/fallback_gcc branch October 15, 2021 11:42
KristofferC added a commit that referenced this pull request Oct 15, 2021
@KristofferC
fall back to gcc/clang if g++/clang++ not avaiable, but warn about it (…
4ba9497 
…#608)

* fall back to gcc/clang if g++/clang++ not avaiable, but warn about it

(cherry picked from commit cded464)
KristofferC added a commit that referenced this pull request Oct 15, 2021
@KristofferC
fall back to gcc/clang if g++/clang++ not avaiable, but warn about it (…
b6bb85c 
…#608) (#610)

* fall back to gcc/clang if g++/clang++ not avaiable, but warn about it

(cherry picked from commit cded464)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mmiller-max mmiller-max mmiller-max left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The change of compiler in 1.7.4 is breaking situations where one of g++/clang++ isn't installed

2 participants

@KristofferC @mmiller-max