Skip to content

remove warn when detecting dependency on Requires.jl #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021
Merged

remove warn when detecting dependency on Requires.jl #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/PackageCompiler.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,8 +638,6 @@ function restore_default_sysimage()
return nothing
end

const REQUIRES = "Requires" => UUID("ae029012-a4dd-5104-9daa-d747884805df")

function create_pkg_context(project)
project_toml_path = Pkg.Types.projectfile_path(project; strict=true)
if project_toml_path === nothing
Expand All @@ -660,16 +658,6 @@ the project at `app_dir`.
"""
audit_app(app_dir::String) = audit_app(create_pkg_context(app_dir))
function audit_app(ctx::Pkg.Types.Context)
# Check for Requires.jl usage
if REQUIRES in ctx.env.project.deps
@warn "Project has a dependency on Requires.jl, code in `@require` will not be run"
end
for (uuid, pkg) in ctx.env.manifest
if REQUIRES in pkg.deps
@warn "$(pkg.name) has a dependency on Requires.jl, code in `@require` will not be run"
end
end

# Check for build script usage
if isfile(joinpath(dirname(ctx.env.project_file), "deps", "build.jl"))
@warn "Project has a build script, this might indicate that it is not relocatable"
Expand Down