Skip to content

Conversation

@KristofferC
Copy link
Member

Requires has been updated to allow it to work decently with sysimages. Instead of including a file at runtime it now embeds the string in the precompiled file (or sysimage) and evals that string during runtime.

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #547 (d9d3ee8) into master (586a9e8) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
- Coverage   83.08%   83.08%   -0.01%     
==========================================
  Files           2        2              
  Lines         467      461       -6     
==========================================
- Hits          388      383       -5     
+ Misses         79       78       -1     
Impacted Files Coverage Δ
src/PackageCompiler.jl 81.75% <ø> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 586a9e8...d9d3ee8. Read the comment docs.

@KristofferC KristofferC merged commit dfe39c7 into master Sep 23, 2021
@KristofferC KristofferC deleted the kc/remove_requires_warn branch September 23, 2021 10:02
@toollu
Copy link

toollu commented Oct 4, 2021

Requires has been updated to allow it to work decently with sysimages. Instead of including a file at runtime it now embeds the string in the precompiled file (or sysimage) and evals that string during runtime.

On which release of Requires.jl was this fix? The latest release is 1.1.3 but I cannot see the mentioned precompile file embedding in there? Is the change merged yet on Requires.jl?

@KristofferC
Copy link
Member Author

JuliaPackaging/Requires.jl#85 is the specific PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants