Skip to content

Non-throwing is_identifier_[start_]char #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pfitzseb merged 3 commits into from
Aug 31, 2022
Merged

Non-throwing is_identifier_[start_]char #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96a3010
non-throwing is_identifier_start_char
pfitzseb Aug 30, 2022
614bfaf
non-throwing is_identifier_char
pfitzseb Aug 30, 2022
48520d3
Check Base.ismalformed instead
pfitzseb Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/tokenize_utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,19 @@ const EOF_CHAR = typemax(Char)

function is_identifier_char(c::Char)
c == EOF_CHAR && return false
Base.ismalformed(c) && return false
return Base.is_id_char(c)
end

function is_identifier_start_char(c::Char)
c == EOF_CHAR && return false
Base.ismalformed(c) && return false
return Base.is_id_start_char(c)
end

# Chars that we will never allow to be part of a valid non-operator identifier
function is_never_id_char(ch::Char)
Base.ismalformed(ch) && return true
cat = Unicode.category_code(ch)
c = UInt32(ch)
return (
Expand Down
7 changes: 7 additions & 0 deletions test/tokenize.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,4 +909,11 @@ end
@test strtok("a .&&₁ b") == ["a", " ", ".&&", "₁", " ", "b", ""]
end

@testset "is_identifier[_start]_char" begin
malformed = first("\xe2")
@test Tokenize.is_identifier_char(malformed) == false
@test Tokenize.is_identifier_start_char(malformed) == false
@test Tokenize.is_never_id_char(malformed) == true
end

end