Skip to content

Non-throwing is_identifier_[start_]char#84

Merged
pfitzseb merged 3 commits intomainfrom
sp/is_identifier_start_char-nothrow
Aug 31, 2022
Merged

Non-throwing is_identifier_[start_]char#84
pfitzseb merged 3 commits intomainfrom
sp/is_identifier_start_char-nothrow

Conversation

@pfitzseb
Copy link
Copy Markdown
Member

No description provided.

@pfitzseb pfitzseb marked this pull request as ready for review August 30, 2022 12:35
Comment thread src/tokenize_utils.jl Outdated
@pfitzseb pfitzseb force-pushed the sp/is_identifier_start_char-nothrow branch from a377f85 to 614bfaf Compare August 30, 2022 12:59
Comment thread src/tokenize_utils.jl Outdated
Copy link
Copy Markdown
Member

@c42f c42f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could do with a test case.

@pfitzseb pfitzseb requested a review from c42f August 31, 2022 09:18
@pfitzseb pfitzseb force-pushed the sp/is_identifier_start_char-nothrow branch 5 times, most recently from f143218 to d5edd2e Compare August 31, 2022 09:28
@pfitzseb pfitzseb force-pushed the sp/is_identifier_start_char-nothrow branch from d5edd2e to 48520d3 Compare August 31, 2022 09:29
Copy link
Copy Markdown
Member

@c42f c42f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@pfitzseb pfitzseb merged commit 660ed65 into main Aug 31, 2022
@pfitzseb pfitzseb deleted the sp/is_identifier_start_char-nothrow branch August 31, 2022 23:03
c42f pushed a commit to JuliaLang/julia that referenced this pull request Oct 17, 2025
…dentifier_start_char-nothrow

Non-throwing is_identifier_[start_]char
topolarity pushed a commit to JuliaLang/julia that referenced this pull request Nov 14, 2025
…dentifier_start_char-nothrow

Non-throwing is_identifier_[start_]char
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants