mapreduce: remove block optimization. #2869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requiring multiple launches probably didn't make it worth it anyway, and it introduces complexities wrt. the launch configuration, having to recompile and re-compute the size of the partial reduction.
|
Thank you again for the fix @maleadt! Would it be possible to get a new tagged release (v5.8.4?)? This would fix a lot of simulation scripts. |
Member
Author
|
I'll create a backport release. |
maleadt
added a commit
that referenced
this pull request
Sep 3, 2025
Requiring multiple launches probably didn't make it worth it anyway, and it introduces complexities wrt. the launch configuration, having to recompile and re-compute the size of the partial reduction.
Member
|
This seems to cause a pretty nasty performance regression for reductions that used the optimizations. 
|
christiangnrd
added a commit
to christiangnrd/CUDA.jl
that referenced
this pull request
Sep 5, 2025
This reverts commit 5f1ef7d.
Member
Author
|
Thanks for catching this. There was a report on Slack as well. |
kshyatt
pushed a commit
to christiangnrd/CUDA.jl
that referenced
this pull request
Sep 9, 2025
This reverts commit 5f1ef7d.
christiangnrd
added a commit
to christiangnrd/CUDA.jl
that referenced
this pull request
Sep 10, 2025
This reverts commit 5f1ef7d.
maleadt
added a commit
that referenced
this pull request
Sep 22, 2025
Requiring multiple launches probably didn't make it worth it anyway, and it introduces complexities wrt. the launch configuration, having to recompile and re-compute the size of the partial reduction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring multiple launches probably didn't make it worth it anyway, and it introduces complexities wrt. the launch configuration, having to recompile and re-compute the size of the partial reduction.
Should fix #2863