-
Notifications
You must be signed in to change notification settings - Fork 258
(0.100.1) Set CUDA.jl compatibility to v5.9+ #4824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Environment fails to initialize on Buildkite. Looks like there's a package version conflict because CUDA.jl v5.9.0 wants PrettyTables.jl v3 but AMDGPU.jl v2.1.0 wants PrettyTables.jl v2. The |
navidcy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Sure, happy to tag a patch for this |
|
FYI just checked and this PR indeed solves all the above-mentioned issues (at least with the MWEs). I'll merge and tag a new version when tests pass. |
|
Note: I did run into a weird error with CUDA v5.9.0 when summing two CuArrays over a subset of their dimensions giving unexpectedly different results when repeated (despite the CuArrays content did not change).... That lead me to discovered that CUDA v5.8.4 and v5.9.0 suffer from JuliaGPU/CUDA.jl#2903 which was solved by JuliaGPU/CUDA.jl#2907 but is not yet included in a tagged release of CUDA. |
CUDA.jl v5.9.0 includes JuliaGPU/CUDA.jl#2869 which resolves a bunch of issues here so I think we should set the
[compat]entry for CUDA.jl to v5.9+.Technically v5.8.4 also includes the fixes although there's only one commit difference between them so I went for v5.9.
Resolves #4047
Resolves #4694
Resolves #4663