Skip to content

Conversation

@ali-ramadhan
Copy link
Member

CUDA.jl v5.9.0 includes JuliaGPU/CUDA.jl#2869 which resolves a bunch of issues here so I think we should set the [compat] entry for CUDA.jl to v5.9+.

Technically v5.8.4 also includes the fixes although there's only one commit difference between them so I went for v5.9.

Resolves #4047
Resolves #4694
Resolves #4663

@ali-ramadhan
Copy link
Member Author

ali-ramadhan commented Sep 30, 2025

Environment fails to initialize on Buildkite. Looks like there's a package version conflict because CUDA.jl v5.9.0 wants PrettyTables.jl v3 but AMDGPU.jl v2.1.0 wants PrettyTables.jl v2.

The [compat] entry for AMDGPU.jl has already been updated to include PrettyTables.jl v3 (JuliaGPU/AMDGPU.jl#829) so I think we just need to wait for a new version of AMDGPU.jl to be tagged and released.

@navidcy navidcy added the GPU 👾 Where Oceananigans gets its powers from label Oct 1, 2025
@navidcy navidcy self-requested a review October 6, 2025 18:31
Copy link
Member

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure it actually resolve #4047, #4694, and #4663?

@tomchor
Copy link
Collaborator

tomchor commented Oct 6, 2025

Are we sure it actually resolve #4047, #4694, and #4663?

I can double-check, but it has for me since v5.8.4 in all the MWEs I tried.

I also think we should tag a patch release here since it solves these important bugs. What do people think?

@navidcy
Copy link
Member

navidcy commented Oct 6, 2025

Sure, happy to tag a patch for this

@tomchor tomchor changed the title Set CUDA.jl compatibility to v5.9+ (0.100.1) Set CUDA.jl compatibility to v5.9+ Oct 6, 2025
@tomchor
Copy link
Collaborator

tomchor commented Oct 6, 2025

FYI just checked and this PR indeed solves all the above-mentioned issues (at least with the MWEs). I'll merge and tag a new version when tests pass.

@tomchor tomchor merged commit a09178c into main Oct 6, 2025
69 checks passed
@tomchor tomchor deleted the ali/compat-cuda-v5.9 branch October 6, 2025 22:46
@navidcy
Copy link
Member

navidcy commented Oct 7, 2025

Note: I did run into a weird error with CUDA v5.9.0 when summing two CuArrays over a subset of their dimensions giving unexpectedly different results when repeated (despite the CuArrays content did not change).... That lead me to discovered that CUDA v5.8.4 and v5.9.0 suffer from JuliaGPU/CUDA.jl#2903 which was solved by JuliaGPU/CUDA.jl#2907 but is not yet included in a tagged release of CUDA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GPU 👾 Where Oceananigans gets its powers from

Projects

None yet

4 participants