-
Notifications
You must be signed in to change notification settings - Fork 5
Split out background submodule #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 94.70% 93.48% -1.22%
==========================================
Files 11 8 -3
Lines 736 599 -137
==========================================
- Hits 697 560 -137
Misses 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Alright, BackgroundMeshes.jl is registered now and things are looking green here (except for the small codecov drop, idk why it's doing that) |
cgarling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, I don't see any issues. Thanks Ian!
Co-authored-by: Chris Garling <[email protected]>
|
Thanks all! Will merge once CI has finished |
Doc preview: https://juliaastro.github.io/Photometry.jl/previews/PR95/
To-do
Once that package is registered, this bit can be removed from the package Project.toml for Julia v1.10 compat