Skip to content

Conversation

@icweaver
Copy link
Member

@icweaver icweaver commented Oct 24, 2025

Doc preview: https://juliaastro.github.io/Photometry.jl/previews/PR95/

To-do

  • Once that package is registered, this bit can be removed from the package Project.toml for Julia v1.10 compat

    - [sources]
    - BackgroundMeshes = {url = "https://github.com/JuliaAstro/BackgroundMeshes.jl"}

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.48%. Comparing base (cde645f) to head (eb4c538).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   94.70%   93.48%   -1.22%     
==========================================
  Files          11        8       -3     
  Lines         736      599     -137     
==========================================
- Hits          697      560     -137     
  Misses         39       39              
Flag Coverage Δ
unittests 93.48% <ø> (-1.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@icweaver icweaver marked this pull request as draft October 24, 2025 10:28
@icweaver icweaver marked this pull request as ready for review October 24, 2025 10:42
@icweaver icweaver linked an issue Oct 24, 2025 that may be closed by this pull request
@icweaver icweaver marked this pull request as draft October 25, 2025 00:34
@icweaver
Copy link
Member Author

Alright, BackgroundMeshes.jl is registered now and things are looking green here (except for the small codecov drop, idk why it's doing that)

@icweaver icweaver marked this pull request as ready for review October 31, 2025 03:59
Copy link
Member

@cgarling cgarling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I don't see any issues. Thanks Ian!

@icweaver
Copy link
Member Author

icweaver commented Nov 1, 2025

Thanks all! Will merge once CI has finished

@icweaver icweaver merged commit 1adeb67 into main Nov 1, 2025
12 of 13 checks passed
@icweaver icweaver deleted the backgroundmeshes-migration branch November 1, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use BackgroundMeshes.jl?

3 participants