Register

[icweaver]

Getting things spruced up a bit so Photometry.jl can depend on it.

Doc preview:https://juliaastro.org/BackgroundMeshes.jl/previews/PR19/

Closes: #14

To-do:

• try [workspace]
  • i love i

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a1b00f5) to head (c5c39c0).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          113       114    +1     
=========================================
+ Hits           113       114    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[icweaver]

It looks like codecov dropped to 0 in this commit b9790c5. Am I doing something wrong?

[giordano]

No tests are running: https://github.com/JuliaAstro/BackgroundMeshes.jl/actions/runs/18809773600/job/53669148389?pr=19#step:6:185

[giordano]

I'm not convinced the pdw() at https://github.com/JuliaTesting/ParallelTestRunner.jl/blob/3aac7bbcc03aab7d21d79bcfce2e7ca4f4d0ce7c/src/ParallelTestRunner.jl#L689 is right. I don't have a better suggestions for a default value though.

See what I did in Enzyme: https://github.com/EnzymeAD/Enzyme.jl/blob/2cd186bee0195dc5eb3eebc6a599ce56676e4e0f/test/runtests.jl#L5-L6 and then passed it in https://github.com/EnzymeAD/Enzyme.jl/blob/2cd186bee0195dc5eb3eebc6a599ce56676e4e0f/test/runtests.jl#L72.

[giordano]

Well, this is still not finding any tests?

[icweaver]

hmmm, lemme see if I can peek at what @__DIR__ and find_tests is returning

[icweaver]

huh, is it typical for github CI to nest dirs like this?

@__DIR__ = "/home/runner/work/BackgroundMeshes.jl/BackgroundMeshes.jl/test"

[giordano]

Yes, that's correct: /home/runner/work/<repo name> is the workspace, then you cloned the repo in it, so you get /home/runner/work/<repo name>/<repo name>

[icweaver]

Interesting, ok. The search continues

[icweaver]

ugggh found it. I just can't type. Should be verbose --> --verbose

[icweaver]

Alrighty, things are green now =]

cc: @cgarling @abhro

[cgarling]

Looks good Ian, thanks for the work! Only couple minor suggestions

[icweaver]

Awesome, should be in now, thanks Chris!