Skip to content

Generalize from Array to DenseArray where possible in stridelayout #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tokazama merged 5 commits into from
Mar 13, 2022
Merged

Generalize from Array to DenseArray where possible in stridelayout #243

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dae5f3b
Generalize from `Array` to `DenseArray` where possible in stridelayout
brenhinkeller Feb 13, 2022
571e365
Bump version number I suppose
brenhinkeller Feb 14, 2022
676d4af
Have to subtype DenseArray rather than substitute directly
brenhinkeller Feb 14, 2022
42513d8
Merge branch 'master' into master
brenhinkeller Mar 11, 2022
e1cf4dc
Bump version to 5.0.3
brenhinkeller Mar 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ArrayInterface"
uuid = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"
version = "4.0.3"
version = "4.0.4"

[deps]
Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
Expand Down
4 changes: 2 additions & 2 deletions src/stridelayout.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ function contiguous_axis(::Type{T}) where {T}
return contiguous_axis(parent_type(T))
end
end
contiguous_axis(::Type{<:Array}) = One()
contiguous_axis(::Type{<:DenseArray}) = One()
contiguous_axis(::Type{<:BitArray}) = One()
contiguous_axis(::Type{<:AbstractRange}) = One()
contiguous_axis(::Type{<:Tuple}) = One()
Expand Down Expand Up @@ -220,7 +220,7 @@ function stride_rank(::Type{T}) where {T}
return stride_rank(parent_type(T))
end
end
stride_rank(::Type{Array{T,N}}) where {T,N} = nstatic(Val(N))
stride_rank(::Type{DenseArray{T,N}}) where {T,N} = nstatic(Val(N))
stride_rank(::Type{BitArray{N}}) where {N} = nstatic(Val(N))
stride_rank(::Type{<:AbstractRange}) = (One(),)
stride_rank(::Type{<:Tuple}) = (One(),)
Expand Down