-
Notifications
You must be signed in to change notification settings - Fork 39
Generalize from Array to DenseArray where possible in stridelayout
#243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Version number not found!?!
|
https://github.com/JuliaArrays/ArrayInterface.jl/runs/5182799084?check_suite_focus=true#step:6:213 @Tokazama We should revert on Friday if this all doesn't get fixed. Downstream shouldn't be failing for more than a week or two without a downstream PR. |
|
I think this makes sense, but as this is expressly for LoopVectorization support, I'd like to see But LV could also depend on this and explicitly test and document a simple API for adding LV support to custom array types. |
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
=======================================
Coverage 89.14% 89.14%
=======================================
Files 11 11
Lines 1751 1751
=======================================
Hits 1561 1561
Misses 190 190
Continue to review full report at Codecov.
|
|
No rush on my end! This'll ultimately hopefully support LV of |
|
Any progress on the downstream stuff lately @Tokazama? I'd try to help, but a lot of the LV internals are still beyond me |
|
Sorry I've been recovering from COVID the last week and haven't been very active on GitHub. LoopVectorization has some odd failures that I don't understand why they occur with the change in question. |
|
Is this potentially back on the table now? Looks like downstream tests are passing |
|
Oh hmm, are these expected? It was all green before the rerun.. Seems like something is broken on Nightly but that might be unrelated? I can't see the logs though due to some permissions setting. |
|
This is an inference issue we've ran into on nightly that I'm pretty sure is unrelated |
|
@brenhinkeller, if you think this should be released in a new update then there needs to be an update to Project.toml too. |
|
Version updated! |
This would help enable LoopVectorization of custom array types that subtype
<: DenseArray <: AbstractArray. SinceDenseArrayis defined to be column-majorthis should be kosher AFAIU.