-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
13 / 1313 of 13 issues completedLabels
creationepicTracks a major feature spanning multiple issuesTracks a major feature spanning multiple issuesv0.9validationValidation rules and error checkingValidation rules and error checking
Milestone
Description
Overview
Comprehensive validation coverage for the character creation system. This epic addresses all identified gaps between the current 13 server-side validators, client-side budget context, and component-level inline validation.
Priority Tiers
P0 — Critical (blocks usability)
- Display server-side finalization validation errors to user #252 — Display server-side finalization validation errors to user
P1 — Critical (data integrity)
- Server-side validation for priority-metatype-path consistency #253 — Server-side validation for priority-metatype-path consistency
- Spell validation: duplicate detection and tradition compatibility #254 — Spell validation: duplicate detection and tradition compatibility
- Adept power server-side validation (PP totals, prerequisites, duplicates) #255 — Adept power server-side validation (PP totals, prerequisites, duplicates)
- Server-side validation: require tradition selection for magicians and mystic adepts #267 — Require tradition selection for magicians and mystic adepts
P2 — High (rule enforcement gaps)
- Identity/SIN validation: rating ranges and license constraints #256 — Identity/SIN validation: rating ranges and license constraints
- Foci bonding karma validation #257 — Foci bonding karma validation
- Real-time equipment availability and legality feedback #258 — Real-time equipment availability and legality feedback
- Vehicle and drone availability/legality validation #259 — Vehicle and drone availability/legality validation
- Knowledge skill and language duplicate detection #260 — Knowledge skill and language duplicate detection
P3 — Medium (defense in depth)
- Server-side nuyen and karma budget recalculation #261 — Server-side nuyen and karma budget recalculation
- Augmentation capacity and grade validation #262 — Augmentation capacity and grade validation
- Skill validation gaps: minimum allocation and Aptitude enforcement #263 — Skill validation gaps: minimum allocation and Aptitude enforcement
P4 — Low (quality of life)
- Minor validation gaps: character info, contacts, armor stacking #264 — Minor validation gaps: character info, contacts, armor stacking
Current Validation Strengths
- Attribute min/max bounds (server + client)
- Quality karma limits and prerequisites (server + client)
- Budget overspend detection (client-side comprehensive)
- Knowledge/language rules (detailed, Bilingual-aware)
- Contact budget rules (karma overflow handling)
- Complex form validation (duplicates, catalog, limits)
- Skill group constraints
Architecture
The validation system has three layers:
- 13 server-side validators in
lib/rules/validation/character-validator.ts - Budget context in
lib/contexts/CreationBudgetContext.tsx - Component-level inline validation in each creation card
Recommended Approach
- Start with Display server-side finalization validation errors to user #252 (error display) — unlocks visibility for all other validators
- Then P1 items which fix data integrity holes
- P2 items add missing rule enforcement
- P3/P4 are defense-in-depth and polish
Reactions are currently unavailable
Sub-issues
Metadata
Metadata
Assignees
Labels
creationepicTracks a major feature spanning multiple issuesTracks a major feature spanning multiple issuesv0.9validationValidation rules and error checkingValidation rules and error checking