Skip to content

Identity/SIN validation: rating ranges and license constraints #256

@Jasrags

Description

@Jasrags

Problem

The identity validation only checks that a SIN and lifestyle exist. It does not validate:

  1. SIN rating range: Fake SINs should be rated 1-6. No bounds checking.
  2. License rating ≤ SIN rating: SR5 rule — a license rating cannot exceed the rating of the fake SIN it's attached to. Not checked.
  3. Real SIN implications: Characters with a Real SIN (National or Corporate) have specific restrictions that aren't validated.

Acceptance Criteria

  • Server-side validator checks fake SIN ratings are 1-6
  • Server-side validator checks license ratings do not exceed their parent SIN rating
  • Client-side component surfaces these errors inline
  • Tests for out-of-range SINs and license > SIN violations

Priority

P2 — High

Files

  • lib/rules/validation/character-validator.ts (extend identityValidator)
  • components/creation/identities/IdentitiesCard.tsx

Metadata

Metadata

Assignees

Labels

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions