-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Labels
creationenhancementNew feature or requestNew feature or requesthigh-priorityImportant - address soonImportant - address soonvalidationValidation rules and error checkingValidation rules and error checking
Milestone
Description
Problem
The identity validation only checks that a SIN and lifestyle exist. It does not validate:
- SIN rating range: Fake SINs should be rated 1-6. No bounds checking.
- License rating ≤ SIN rating: SR5 rule — a license rating cannot exceed the rating of the fake SIN it's attached to. Not checked.
- Real SIN implications: Characters with a Real SIN (National or Corporate) have specific restrictions that aren't validated.
Acceptance Criteria
- Server-side validator checks fake SIN ratings are 1-6
- Server-side validator checks license ratings do not exceed their parent SIN rating
- Client-side component surfaces these errors inline
- Tests for out-of-range SINs and license > SIN violations
Priority
P2 — High
Files
lib/rules/validation/character-validator.ts(extendidentityValidator)components/creation/identities/IdentitiesCard.tsx
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
creationenhancementNew feature or requestNew feature or requesthigh-priorityImportant - address soonImportant - address soonvalidationValidation rules and error checkingValidation rules and error checking