Skip to content

Skip handling of non-present DOIs #14367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
+22 −17
Merged

Skip handling of non-present DOIs #14367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
addef6a
Skip handling of non-present DOIs
koppor Nov 20, 2025
8e51dd0
Fix state handling in RuleBasedPlainCitationParser
koppor Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ain/java/org/jabref/logic/importer/fetcher/citation/crossref/CrossRefCitationFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,11 @@ public List<BibEntry> getReferences(BibEntry entry) throws FetcherException {
return references.valueStream()
.map(Unchecked.function(reference -> {
String unstructured = reference.at("/unstructured").asText();
String referenceDoi = reference.at("/DOI").asText();
if (referenceDoi == null) {
JsonNode doiNode = reference.at("/DOI");
if (doiNode.isMissingNode()) {
return getBibEntryFromText(parser, unstructured);
} else {
return getBibEntryFromDoi(referenceDoi, unstructured);
return getBibEntryFromDoi(doiNode.asText(), unstructured);
}
}))
.toList();
Expand Down
33 changes: 19 additions & 14 deletions ...b/src/main/java/org/jabref/logic/importer/plaincitation/RuleBasedPlainCitationParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,14 @@
import java.util.regex.Matcher;
import java.util.regex.Pattern;

import org.jabref.logic.importer.FetcherException;
import org.jabref.model.entry.BibEntry;
import org.jabref.model.entry.field.StandardField;
import org.jabref.model.entry.types.EntryType;
import org.jabref.model.entry.types.StandardEntryType;

/**
* Parse a plain citation using regex rules.
* <p>
* TODO: This class is similar to {@link org.jabref.logic.importer.fileformat.pdf.RuleBasedBibliographyPdfImporter}, we need to unify them.
*/
/// Parse a plain citation using regex rules.
///
/// TODO: This class is similar to {@link org.jabref.logic.importer.fileformat.pdf.RuleBasedBibliographyPdfImporter}, we need to unify them.
public class RuleBasedPlainCitationParser implements PlainCitationParser {
private static final String AUTHOR_TAG = "[author_tag]";
private static final String URL_TAG = "[url_tag]";
Expand Down Expand Up @@ -52,16 +49,24 @@ public class RuleBasedPlainCitationParser implements PlainCitationParser {
"(p.)?\\s?\\d+(-\\d+)?",
Pattern.CASE_INSENSITIVE | Pattern.MULTILINE | Pattern.DOTALL);

private final List<String> urls = new ArrayList<>();
private final List<String> authors = new ArrayList<>();
private String year = "";
private String pages = "";
private String title = "";
private boolean isArticle = true;
private String journalOrPublisher = "";
private List<String> urls;
private List<String> authors;
private String year;
private String pages;
private String title;
private boolean isArticle;
private String journalOrPublisher;

@Override
public Optional<BibEntry> parsePlainCitation(String text) throws FetcherException {
public Optional<BibEntry> parsePlainCitation(String text) {
urls = new ArrayList<>();
authors = new ArrayList<>();
year = "";
pages = "";
title = "";
isArticle = true;
journalOrPublisher = "";

String inputWithoutUrls = findUrls(text);
String inputWithoutAuthors = findAuthors(inputWithoutUrls);
String inputWithoutYear = findYear(inputWithoutAuthors);
Expand Down
Loading