Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented Nov 20, 2025

Follow-up to #14357

Somehow, crossref wasn't tested properly.

Also fixes the state handling of RuleBasedPlainCitationParser to allow re-used of the object for each parsing run.

Steps to test

./gradlew :jabkit:run --args="get-cited-works --provider=crossref 10.47397/tb/44-3/tb138kopp-jabref"

Mandatory checks

@koppor koppor added component: JabKit [cli] status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Nov 20, 2025
@Siedlerchr
Copy link
Member

add a test?

@koppor
Copy link
Member Author

koppor commented Nov 20, 2025

add a test?

#Futurework - fetcher is based on the data of the provider. Would take longer to write down different possible returned JSON files. -- Since the fetcher also automatically fetches data from the DOI, it gets even more complicated 😅

@koppor koppor enabled auto-merge November 20, 2025 14:58
@koppor koppor added this pull request to the merge queue Nov 20, 2025
Merged via the queue into main with commit 5d6c2ab Nov 20, 2025
67 of 81 checks passed
@koppor koppor deleted the fix-fetcher branch November 20, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: JabKit [cli] status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants