Refactor formatter cleanup classes#14285
Merged
Merged
Conversation
Refactor Formatter and FieldFormatterCleanups in package org.jabref.logic.cleanup. - Move Formatter to logic.formatter package, as base class of other formatters. - Rename FieldFormatterCleanups to FieldFormatterCleanupActions. - Abstract parsing logic to a new class named FieldFormatterCleanupParser.
Siedlerchr
changed the title
Member
|
@EricW123 Thank you for your contribution. Please fix the the issues discovered by the CI so that the code is proapred for human review. |
koppor
added
the
status: changes-required
…-14280 # Conflicts: # jabgui/src/main/java/org/jabref/gui/cleanup/CleanupPresetPanel.java # jabgui/src/main/java/org/jabref/gui/commonfxcontrols/FieldFormatterCleanupsPanelViewModel.java
github-actions
Bot
removed
the
status: changes-required
Member
|
@EricW123 I took the liberty to merge upstream and to fix merge conflicts. Should be easier to for you, if you want to pick this PR up again. |
koppor
added
the
status: changes-required
Member
|
@EricW123 Tests are still failing. Any interest to continue here or should we free this issue for another contributor? |
calixtus
added
component: cleanup-ops
dev: code-quality
koppor
removed
the
status: changes-required
koppor
approved these changes
Dec 22, 2025
tsantalis
added a commit
to tsantalis/RefactoringMiner
that referenced
this pull request
Dec 22, 2025
JabRef/jabref#14285 Extract And Move Method public serializeActions(actionList List<FieldFormatterCleanup>, newLineSeparator String) : String extracted from public getMetaDataString(actionList List<FieldFormatterCleanup>, newLineSeparator String) : String in class org.jabref.logic.cleanup.FieldFormatterCleanups & moved to class org.jabref.logic.cleanup.FieldFormatterCleanupMapper
maorethians
pushed a commit
to maorethians/RefactoringMiner
that referenced
this pull request
Jun 8, 2026
JabRef/jabref#14285 Extract And Move Method public serializeActions(actionList List<FieldFormatterCleanup>, newLineSeparator String) : String extracted from public getMetaDataString(actionList List<FieldFormatterCleanup>, newLineSeparator String) : String in class org.jabref.logic.cleanup.FieldFormatterCleanups & moved to class org.jabref.logic.cleanup.FieldFormatterCleanupMapper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Formatter and FieldFormatterCleanups in package org.jabref.logic.cleanup.
Closes #14280
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)