Refactor Timer component to provide expiry information #2365
+30
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also resolve the overflow in GetTimeRemaining for long timers
|
Build size and comparison to main:
|
minacode
reviewed
Nov 8, 2025
Contributor
minacode
left a comment
minacode
left a comment
There was a problem hiding this comment.
I think the API design is good and general enough, because you basically just implemented a signed timedelta w.r.t the expiry time. I see no problem with this being to specific for other use cases where timers are needed. Whenever the expiry is not needed, it can easily be ignored.
JF002
approved these changes
Nov 9, 2025
Collaborator
JF002
left a comment
JF002
left a comment
There was a problem hiding this comment.
The API looks good to me. I prefer this option that use a single method to get the complete state of the timer over using 2 methods that return the remaining/expired time.
minacode
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also resolve the overflow in GetTimeRemaining for long timers
Prerequisite for #1971 (@vkareh any feedback please do chip in!)
It's a bit annoying to store a duplicate of the expiry time but I think it's the best way around xTimerGetExpiryTime being undefined after a timer expires
Should the API for timer remaining/since expired be two methods? I went with this as it allows getting the complete state with one function, but maybe this isn't a sensible API for a generic timer component
Untested!