timer: Add ringing and counter

[vkareh]

The timer app currently issues a short buzz once and then disappears. There is no trace left that the timer finished or how long ago. This change makes the motor start ringing and presents a timer counter. The motor will continue the ringing pattern for 10 seconds and the timer counter will finally reset after 60 seconds.

[github-actions]

Build size and comparison to main:

Section	Size	Difference
text	382796B	368B
data	944B	0B
bss	22632B	0B

Run in InfiniEmu

[mark9064]

Works great, huge usability improvement for the timer. Been running this for a while and it makes me a more consistent cook for sure!

I think it would be nice if the alarm and timer had different vibration patterns, but vibration needs to be overhauled anyway so this is good to go for now IMO

[mark9064]

I see why you changed this (count up after ringing), but we probably want to avoid relying on UB

[rnwgnr]

Tested this today while cooking and this is indeed a great usability improvement for the timer.

Until now i missed a lot of the alarms, the vibration is just too short. Great work.

[mark9064]

It's a bit hidden so just in case I responded to the timer method semantics problem here: https://github.com/InfiniTimeOrg/InfiniTime/pull/1971/files#r2492311746

Would be super great to get this in for 1.16 which we're hoping to release in the next few days :)

[JF002]

I've just tested this PR and it looks very good, thanks @vkareh !
One thing I noticed : when the timer reaches 00:00, it looks like it stays on that value for 2 seconds before showing 00:01. It's not a big deal, but I think it makes the "elapsed for xx seconds" value off by one second.

See this video : https://github.com/user-attachments/assets/2d6ba5c3-43c0-42fa-92e8-1779267c42b2

[mark9064]

I think this is the correct behaviour since the time always rounds to zero.

actual | shown
 5.00 | 5
 4.99 | 4
 4.00 | 4
...
 1.00 | 1
 0.99 | 0
 0.00 | 0
-0.99 | 0
-1.00 | 1
-1.99 | 1
-2.00 | 2

so you should expect it to show 0 for 2 seconds (from time +1 to -1)

[JF002]

@mark9064 Good point, that makes sense! 👍

[mark9064]

@vkareh #2365 is in :) let me know if it all works ok when you get around to rebasing on to it

[DavisNT]

Could it be possible to add an option to ring indefinitely (in many cases people will not notice the 10 seconds ringing, especially if the timer is used during physical activity/sports)?

[mark9064]

I totally get where you're coming from but I think it'd be best to choose one sensible default here. At least how I've been using the timer 10s ringing has felt good to me, even if I'm moving about I definitely notice it before it stops. I'm not sure if you've had the chance to try this PR yet, but if not maybe give it a go and see how you find 10s? Maybe it's more noticeable than you'd think :)

[vkareh]

@mark9064 - just rebased. Had to fix some conflicts, but it all led to basically dropping the last commit, as it became a no-op 🎉

[mark9064]

I'd really like to see this use the expired field of the timer rather than tracking that state externally. I've pointed out a few consequences of doing that but there's definitely more changes that would follow

However I don't think this is a release blocker, it could be refactored later

[vkareh]

@mark9064

I'd really like to see this use the expired field of the timer rather than tracking that state externally. I've pointed out a few consequences of doing that but there's definitely more changes that would follow

These are really good suggestions. I've implemented them and it made the code a lot cleaner. Thanks!