Skip to content

fcrackzip: rename binary zipinfo to fcrackzipinfo#115110

Closed
cho-m wants to merge 1 commit intoHomebrew:masterfrom
cho-m:fcrackzip-rename-zipinfo
Closed

fcrackzip: rename binary zipinfo to fcrackzipinfo#115110
cho-m wants to merge 1 commit intoHomebrew:masterfrom
cho-m:fcrackzip-rename-zipinfo

Conversation

@cho-m
Copy link
Copy Markdown
Member

@cho-m cho-m commented Nov 7, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Conflict seen in #113581

==> Pouring fcrackzip--1.0.x86_64_linux.bottle.tar.gz
  Error: The `brew link` step did not complete successfully
  The formula built, but is not symlinked into /home/linuxbrew/.linuxbrew
  Could not symlink bin/zipinfo
  Target /home/linuxbrew/.linuxbrew/bin/zipinfo
  is a symlink belonging to unzip. You can unlink it:
    brew unlink unzip
  
  To force the link and overwrite all conflicting files:
    brew link --overwrite fcrackzip
  
  To list all files that would be deleted:
    brew link --overwrite --dry-run fcrackzip
  
  Possible conflicting files are:
  /home/linuxbrew/.linuxbrew/bin/zipinfo -> /home/linuxbrew/.linuxbrew/Cellar/unzip/6.0_8/bin/zipinfo

Comment thread Formula/fcrackzip.rb
Comment on lines +34 to +35
# Avoid conflict with `unzip` on Linux and shadowing `/usr/bin/zipinfo` on macOS
bin.install bin/"zipinfo" => "fcrackzipinfo"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrewTestBot
Copy link
Copy Markdown
Contributor

🤖 A scheduled task has triggered a merge.

@cho-m cho-m deleted the fcrackzip-rename-zipinfo branch December 21, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants