firefoxpwa: use openssl@3, bzip2: add pkgconfig file

[cho-m]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[SMillerDev]

Can we not add this as a patch?

[cho-m]

The 1.1.x repo is separate work from 1.0.x repo (ref: https://sourceware.org/bzip2/downloads.html) and uses different build tools (previously autotools and now cmake/meson) rather than 1.0.x Makefile.

Some Linux distros have been maintaining their own copies of the pkgconfig file, e.g.:

• Alpine - https://git.alpinelinux.org/aports/tree/main/bzip2/bzip2.pc.in
• Arch - https://github.com/archlinux/svntogit-packages/blob/packages/bzip2/trunk/bzip2.pc
• Fedora - https://src.fedoraproject.org/rpms/bzip2/blob/rawhide/f/bzip2.pc

Was mainly testing that this worked. It looks like the rust bindings did dynamically link now (ref: https://github.com/alexcrichton/bzip2-rs/blob/bzip2-sys-0.1.10+1.0.8/bzip2-sys/build.rs#L16-L22)

[cho-m]

Linux errors are unrelated:

• brew test --retry --verbose bde - Issue with default C++ standard change from GCC-5 to GCC-11. Rebottled to get it working
• brew test --retry --verbose cucumber-cpp - Fixed with rebottle
• brew test --retry --verbose emscripten - emscripten: fix Linux test when sdl12-compat is installed #117078
• brew test --retry --verbose beast - beagle: build using openjdk@11 #117120
• brew linkage --test pyside@2, brew test --retry --verbose pyside@2 - pyside@2, coin3d: remove Linux bottle #117035
• brew test --retry --verbose quazip - quazip: modernize cmake build steps #117107
• brew install gnirehtet - gnirehtet: update cargo.lock to fix build with rust 1.64.0 #117139
• brew linkage --test fourstore - fourstore: depend on avahi on Linux. #109825
• brew test --retry --verbose pyflow - Issue with upstream server used for API
• brew test --retry --verbose streamlink - existing self-hosted Linux failure. don't know reason
• brew test --retry --verbose waybackpy - seen in other PRs. don't know reason
• brew install --only-dependencies ansible-lint - issue with Homebrew test-bot that errors when fetching dependency fails on network issue.

[chenrui333]

Merged the emscripten patch PR

[p-linnane]

macOS has rpath issues with gdal

Linux:

Error: 5 failed steps!
brew install gnirehtet
brew test --retry --verbose pyflow
brew test --retry --verbose rpm
brew test --retry --verbose streamlink
brew test --retry --verbose walkmod

pyflow is a known issue, API just redirects to a Heroku landing page
walkmod was deprecated in #118826.

[cho-m]

Looks ready to me now but would like some feedback.

Linux linkage for firefoxpwa is correct:

==> brew linkage --cached firefoxpwa
System libraries:
  /lib/x86_64-linux-gnu/libc.so.6
  /lib/x86_64-linux-gnu/libgcc_s.so.1
  /lib/x86_64-linux-gnu/libm.so.6
Homebrew libraries:
  /home/linuxbrew/.linuxbrew/opt/bzip2/lib/libbz2.so.1.0 (bzip2)
  /home/linuxbrew/.linuxbrew/opt/openssl@3/lib/libcrypto.so.3 (openssl@3)
  /home/linuxbrew/.linuxbrew/opt/openssl@3/lib/libssl.so.3 (openssl@3)

As I mentioned in file changes, these are Linux-only. Can see this via:

❯ cargo tree --target x86_64-apple-darwin --invert bzip2-sys

❯ cargo tree --target x86_64-apple-darwin --invert openssl-sys

❯ cargo tree --target x86_64-unknown-linux-gnu --invert bzip2-sys
bzip2-sys v0.1.11+1.0.8
└── bzip2 v0.4.3
    └── firefoxpwa v0.0.0 (/Users/cho-m/Code/PWAsForFirefox-2.3.0/native)

❯ cargo tree --target x86_64-unknown-linux-gnu --invert openssl-sys
openssl-sys v0.9.80
├── native-tls v0.2.11
│   ├── hyper-tls v0.5.0
│   │   └── reqwest v0.11.13
│   │       └── firefoxpwa v0.0.0 (/Users/cho-m/Code/PWAsForFirefox-2.3.0/native)
│   ├── reqwest v0.11.13 (*)
│   └── tokio-native-tls v0.3.0
│       ├── hyper-tls v0.5.0 (*)
│       └── reqwest v0.11.13 (*)
└── openssl v0.10.45
    └── native-tls v0.2.11 (*)

And manually adding pkg-config file is similar to other Linux distros. I restricted this to Linux as we only build a static library on macOS and we highly prefer system copy of bzip2.

[BrewTestBot]

🤖 A scheduled task has triggered a merge.